signed off by: Prashant prabhakar <[email protected]> #1636
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prash240303 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Superseded by: |
|
/close |
|
@kwilczynski: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for JSON format loggers .
Which issue(s) this PR fixes:
Fixes #1126
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None
Special notes to the reviewer :
Due to a lack of familiarity with JSON loggers and the unavailability of the opportunity to run the project locally due to challenges encountered while setting up CRIO, I regret to acknowledge that I couldn't write test cases for feature. The code I have produced is in my existing knowledge and understanding of the subject . While I aimed to make a meaningful contribution during LFX term 3, the constraints prevented me from delivering a fully tested feature. Despite these limitations, I am committed to showcasing the extent of my engagement and participation within the scope of my capabilities.